[CRIU] [PATCH v5] Add docker phaul driver

Hui Kang hkang.sunysb at gmail.com
Tue Oct 27 06:52:07 PDT 2015


On Tue, Oct 27, 2015 at 4:48 AM, Pavel Emelyanov <xemul at parallels.com> wrote:
>
>>>> Continued from last email.
>>>>
>>>>     while self.pre_dump:
>>>>             self.target_host.start_iter(true)
>>>>             ....
>>>>
>>>>     logging.info("Final dump and restore")
>>>>     self.target_host.start_iter(false)
>>>
>>> Yes, I like the idea, but remember that p_haul_pid.py needs page-server even
>>> for the final dump stage, so passing just False all the time here would be
>>> incorrect.
>>
>> You are right. So how about
>>
>>         whie self.pre_dump:
>>                self.target_host.start_iter(True)
>>                ...
>>
>>         logging.info("Final dump and restore")
>>         self.target_host.start_iter(False OR self.htype.dump_need_ps())
>
> Yes, smth like this, but isn't the
>
>   self.target_host.start_iter(self.htype.dump_need_ps())
>
> enough? I.e. -- without the "False OR" part.

Oops, you are right. I will update the patch soon.

- Hui

>
> -- Pavel
>


More information about the CRIU mailing list