[CRIU] [PATCH] ipc: Don't inject timestamps into informative message

Pavel Emelyanov xemul at parallels.com
Fri Oct 23 08:10:56 PDT 2015


On 10/23/2015 06:06 PM, Cyrill Gorcunov wrote:
> Every print_on_level() injects timestamp, better to
> print it in one pass for readability.
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
> ---
>  ipc_ns.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/ipc_ns.c b/ipc_ns.c
> index 06d31000f3d9..cdeda00e7f49 100644
> --- a/ipc_ns.c
> +++ b/ipc_ns.c
> @@ -37,10 +37,11 @@
>  
>  static void pr_ipc_desc_entry(unsigned int loglevel, const IpcDescEntry *desc)
>  {
> -	print_on_level(loglevel, "id: %-10d key: 0x%08x ", desc->id, desc->key);
> -	print_on_level(loglevel, "uid: %-10d gid: %-10d ", desc->uid, desc->gid);
> -	print_on_level(loglevel, "cuid: %-10d cgid: %-10d ", desc->cuid, desc->cgid);
> -	print_on_level(loglevel, "mode: %-10o ", desc->mode);
> +	print_on_level(loglevel,
> +		       "id: %-10d key: 0x%08x ", desc->id, desc->key,
> +		       "uid: %-10d gid: %-10d ", desc->uid, desc->gid,
> +		       "cuid: %-10d cgid: %-10d ", desc->cuid, desc->cgid,
> +		       "mode: %-10o ", desc->mode);

Are you sure about it?

>  }
>  
>  static void fill_ipc_desc(int id, IpcDescEntry *desc, const struct ipc_perm *ipcp)
> 



More information about the CRIU mailing list