[CRIU] [PATCH 2/4] add a Makefile with a lint target

Tycho Andersen tycho.andersen at canonical.com
Thu Oct 22 12:34:08 PDT 2015


On Thu, Oct 22, 2015 at 10:08:05PM +0400, Nikita Spiridonov wrote:
> Acked-by: Nikita Spiridonov <nspiridonov at odin.com>
> 
> Tycho, thanks for the patch, I think we really need linting in p.haul.
> We can reform code and get rid of some ignores as time goes by, for
> example E302. I also dream of disallowing mixed tabs/spaces (E101), but
> Pavel don't like that idea.

Yep, I think it's a useful tool. FWIW, pep8 says you should use only
spaces. I didn't do any conversions there mostly because I don't have
strong opinions (strict pep8 leads to a lot of fugly code IMO), so the
whitelisted errors in this patch are fine with me.

Anyway, I'm sure we can have more arguments about whitespace in future
patches ;)

Thanks,

Tycho


More information about the CRIU mailing list