[CRIU] [PATCH 0/5] zdtm: (mostly) logging fixes

Kir Kolyshkin kir at odin.com
Wed Oct 21 22:37:21 PDT 2015



On 10/21/2015 10:31 PM, Andrey Vagin wrote:
> 2015-10-22 8:24 GMT+03:00 Andrew Vagin <avagin at odin.com>:
>> On Wed, Oct 21, 2015 at 04:06:11PM -0700, Kir Kolyshkin wrote:
>>> I was glancing through commit 7235e9b and spotted a few places
>>> where the logging is wrong, which dragged me into all this.
>>>
>>> Splitted into separate patches for clarity.
>> Looks like this series is conflicting with my patch:
>> [PATCH] zdtm: return non-zero code in a error case
> Pls, commit my patch and then ack for all these patches;)

I suggest the opposite, as yours is way smaller and easier
to port on top of my set than vise versa, and I already ported it.

>
> Acked-by: Andrew Vagin <avagin at gmail.com>
>
> Thanks!
>
>>> Kir Kolyshkin (5):
>>>    test_msg(): avoid recursion
>>>    zdtm: sanitize pr_perror() usage
>>>    zdtm/live/static/socket-tcpbuf: fix error message
>>>    zdtm unix_sock: don't use errno
>>>    zdtm: introduce and use pr_err()
>>>
>>>   test/zdtm/lib/msg.c                       |  3 ++-
>>>   test/zdtm/lib/tcp.c                       | 12 ++++++------
>>>   test/zdtm/lib/test.c                      |  8 ++++----
>>>   test/zdtm/lib/zdtmtst.h                   |  3 +++
>>>   test/zdtm/live/static/file_fown.c         |  2 +-
>>>   test/zdtm/live/static/packet_sock.c       | 20 ++++++++++----------
>>>   test/zdtm/live/static/packet_sock_mmap.c  |  6 +++---
>>>   test/zdtm/live/static/socket-closed-tcp.c |  4 ++--
>>>   test/zdtm/live/static/socket-tcp.c        |  4 ++--
>>>   test/zdtm/live/static/socket-tcpbuf.c     |  8 ++++----
>>>   test/zdtm/live/static/socket_aio.c        | 18 +++++++++---------
>>>   test/zdtm/live/static/socket_listen.c     | 12 ++++++------
>>>   test/zdtm/live/static/unhashed_proc.c     |  6 +++---
>>>   test/zdtm/live/static/zombie00.c          |  2 +-
>>>   test/zdtm/live/streaming/fifo_loop.c      | 18 +++++++++---------
>>>   test/zdtm/live/streaming/file_aio.c       | 17 ++++++++---------
>>>   test/zdtm/live/streaming/netlink00.c      |  6 +++---
>>>   test/zdtm/live/streaming/pipe_loop00.c    | 10 +++++-----
>>>   test/zdtm/live/streaming/pipe_shared00.c  | 10 +++++-----
>>>   test/zdtm/live/streaming/socket_loop00.c  | 10 +++++-----
>>>   test/zdtm/live/streaming/unix_sock.c      | 13 ++++++-------
>>>   test/zdtm/live/transition/epoll.c         | 20 ++++++++++----------
>>>   test/zdtm/live/transition/file_read.c     |  8 ++++----
>>>   23 files changed, 111 insertions(+), 109 deletions(-)
>>>
>>> --
>>> 2.4.3
>>>



More information about the CRIU mailing list