[CRIU] [PATCH 2/2 v4] fsnotify: Always provide the path for inotify watchees
Cyrill Gorcunov
gorcunov at gmail.com
Mon Oct 19 04:17:10 PDT 2015
On Mon, Oct 19, 2015 at 02:05:32PM +0300, Pavel Emelyanov wrote:
> >
> > This comes from the handle itself, that's how they work. They're
>
> No, no, no :) I'm talking about this
>
> > + openable_fd = openat(mntfd, __path, O_PATH);
> > + if (openable_fd >= 0) {
> > + close(openable_fd);
>
> code. You open _some_ path and state that the inode you get after
> this is the same as you got before with open_by_handle_at(). I say
> this assumption is wrong and should be checked by comparing inodes.
OK, I see what you mean. If the path opened by handle then read
from the self-link would not match the inode the whole complete
kernel is broken. But sure, I'll add this test :-)
More information about the CRIU
mailing list