[CRIU] Looks like stack garbage could be dereferenced in collect_pstree_ids_predump()

Batalov Eugene eabatalov89 at gmail.com
Fri Oct 16 05:34:23 PDT 2015


Sorry. Please ignore this. Everything is ok here.

2015-10-15 19:56 GMT+03:00 Batalov Eugene <eabatalov89 at gmail.com>:

> Hello.
>
> Please take a look at ./cr-dump.c:717-742 lines:
>
> 717: struct pstree_item *item; // local pointer variable isn't initialized
> explicitly
> ...
> // First use of item is here:
> 734     for_each_pstree_item(item) {
>
> // Here is how macro is defined
> 75 #define for_each_pstree_item(pi) \
> 76     for (pi = root_item; pi != NULL; pi = pstree_item_next(pi))
>
> Looks like
> struct pstree_item *item = NULL;
> is needed here.
>
> --
> Best regards,
> Eugene Batalov.
>



-- 
Best regards,
Eugene Batalov.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openvz.org/pipermail/criu/attachments/20151016/56d4ef63/attachment.html>


More information about the CRIU mailing list