[CRIU] [PATCH] mnt: Use ns_mountpoint to open a mount point

[Pavel Emelyanov]

On 10/12/2015 02:07 PM, Cyrill Gorcunov wrote:
> On Mon, Oct 12, 2015 at 01:47:52PM +0300, Pavel Emelyanov wrote:
>>
>>> 2) Opening mountpoints should be done using @ns_mountpoint as
>>>    a reference. This is a second part of the bug above fixed.
>>>    That is _this_ patch.
>>>
>>> Now once mountpoints order and their openup is fixed we faced
>>> problems with opening watchees in fsnotify code. And here
>>> two patches which should address it.
>>
>> Can I see the test that triggers this BUG?
> 
> Didn't invent one yet. I'm testing it on failing tamplate,
> but definitely will create one.

OK

>>> 3) Andrew's fsnotify: save mnt_id with path (which address
>>>    tmpfs only)
>>
>> Tmpfs? Why tmpfs only, fro my perspective it should fix anything.
>> BTW, I recall there was another issue with unlinked files on tmpfs.
>> How about that one?
> 
> It doesn't fix everything, as we found there is problem with bindmount
> case. So Andrew did a fix for tmpfs and a test for it. The bindmount
> case is anothe problem and gonna be addressed on top.

Wait, the fix saving mnt_id on watch image has nothing to do with
tmpfs, it just happens that we test it using tmpfs mount.

> What about unlinked files, mind to refresh?

open_handle() failed for unlinked tmpfs file with -ESTALE and our logic
picking path for tmpfs unconditionally didn't work.

-- Pavel