[CRIU] [PATCH] mnt: Use ns_mountpoint to open a mount point

Pavel Emelyanov xemul at parallels.com
Mon Oct 12 03:22:03 PDT 2015


On 10/12/2015 01:05 PM, Cyrill Gorcunov wrote:
> On Mon, Oct 12, 2015 at 12:56:55PM +0300, Pavel Emelyanov wrote:
>> On 10/09/2015 06:59 PM, Cyrill Gorcunov wrote:
>>> From: Andrew Vagin <avagin at openvz.org>
>>>
>>> open_mountpoint helper is called when mount namespace are
>>> already restored so we have to use local paths.
>>
>> 2 questions from my side:
>>
>> 1. How is this connected with the patch "fsnotify: save mnt_id with path"?
> 
> It's unconnected actually. The Andrew's patch adds mnt_id for tmpfs as far
> as I remeeber. But my patch for "guessing" the path (which I'm still
> working on) based on this patch. Still note that there mount.c code is
> modified as well which is needed to fix debian-8 nested mountnamespace
> problems.

OK, so that's the 3rd issue fixed by this patch? Let me summarize

1. watch from another namespace (fixed, commiteed)
2. watch from bind mount with weird name (kernel is read for details)
3. this issue

Right? If yes, what are the circumstances when we face _this_ one?

>> 2. Is the test from that set catches this bug?
> 
> Not yet.
> .
> 



More information about the CRIU mailing list