[CRIU] [PATCH 4/7] p.haul: implement migration over existing connections

[Nikita Spiridonov]

On Thu, 2015-10-08 at 13:06 +0300, Pavel Emelyanov wrote:
> On 10/06/2015 06:28 PM, Nikita Spiridonov wrote:
> > Remove standalone mode, p.haul now can work only over existing
> > connections specified via command line arguments as file
> > descriptors.
> > 
> > Three arguments required - --fdrpc for rpc calls, --fdmem for c/r
> > images migration and --fdfs for disk migration. Expect that each
> > file descriptor represent socket opened in blocking mode with domain
> > AF_INET and type SOCK_STREAM.
> 
> What's the code that "expects" this? Can it break if I put there a pipe?
> 
> > --to option preserved for now in p.haul for disk migration via
> > rsync, it will be unused soon at least for vz module which will
> > use ploop for disk migration.
> > 
> > Signed-off-by: Nikita Spiridonov <nspiridonov at odin.com>
> > ---
> >  p.haul                     |   51 +++++++++++++++++++------------
> >  p.haul-service             |   31 ++++++++++++-------
> >  phaul/fs_haul_shared.py    |    2 +-
> >  phaul/fs_haul_subtree.py   |    5 ++-
> >  phaul/p_haul_connection.py |   44 +++++++++++++++++++++++++++
> >  phaul/p_haul_iters.py      |   16 +++++-----
> >  phaul/p_haul_service.py    |   29 ++++++++----------
> >  phaul/util.py              |    1 -
> >  phaul/xem_rpc.py           |   71 +++++++++++--------------------------------
> >  phaul/xem_rpc_client.py    |   18 +----------
> >  10 files changed, 140 insertions(+), 128 deletions(-)
> >  create mode 100644 phaul/p_haul_connection.py
> 
> Please, split the patch. Renames should go separately at least, removal of
> unused code in util.py too.
> 

Okay, already done actually, resend rebased V2 patchset after Adrian
patches will be applied (there is a lot of changes in my patchset again)

> Also note, that private class members are preceded with double-underscore,
> not singe (phaul_service._mem_sk for example).
> 
> -- Pavel