[CRIU] [PATCH 1/7] aarch64:get_task_regs(): use pr_perror()

Andrew Vagin avagin at odin.com
Wed Oct 7 23:34:31 PDT 2015


Acked-by: Andrew Vagin <avagin at odin.com>
for all except the 6-th patch

Thanks.

On Wed, Oct 07, 2015 at 09:19:47AM -0700, Kir Kolyshkin wrote:
> As ptrace() sets errno, it makes sense to use pr_perror().
> This also fixes the bug of missing '\n'.
> 
> Signed-off-by: Kir Kolyshkin <kir at openvz.org>
> ---
>  arch/aarch64/crtools.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/aarch64/crtools.c b/arch/aarch64/crtools.c
> index 90af289..9dc2777 100644
> --- a/arch/aarch64/crtools.c
> +++ b/arch/aarch64/crtools.c
> @@ -92,14 +92,14 @@ int get_task_regs(pid_t pid, user_regs_struct_t regs, CoreEntry *core)
>  	iov.iov_base = &regs;
>  	iov.iov_len = sizeof(user_regs_struct_t);
>  	if ((ret = ptrace(PTRACE_GETREGSET, pid, NT_PRSTATUS, &iov))) {
> -		pr_err("Failed to obtain CPU registers for %d!", pid);
> +		pr_perror("Failed to obtain CPU registers for %d", pid);
>  		goto err;
>  	}
>  
>  	iov.iov_base = &fpsimd;
>  	iov.iov_len = sizeof(fpsimd);
>  	if ((ret = ptrace(PTRACE_GETREGSET, pid, NT_PRFPREG, &iov))) {
> -		pr_err("Failed to obtain FPU registers for %d!", pid);
> +		pr_perror("Failed to obtain FPU registers for %d", pid);
>  		goto err;
>  	}
>  
> -- 
> 2.4.3
> 
> _______________________________________________
> CRIU mailing list
> CRIU at openvz.org
> https://lists.openvz.org/mailman/listinfo/criu


More information about the CRIU mailing list