[CRIU] [PATCH v2] Introduce feature check via RPC

[Pavel Emelyanov]

On 10/07/2015 04:31 PM, Adrian Reber wrote:
> On Wed, Oct 07, 2015 at 03:24:25PM +0300, Pavel Emelyanov wrote:
>>> @@ -134,6 +144,12 @@ message criu_req {
>>>  	 * for all request types.
>>>  	 */
>>>  	optional bool			keep_open	= 4;
>>> +	/*
>>> +	 * feat_chk can be used to query which features
>>> +	 * are supported by the installed criu/kernel
>>> +	 * via RPC.
>>> +	 */
>>> +	optional int32			feat_chk	= 5;
>>
>> What if we run out of bits in the future? Another issue with bit-field
>> in protobuf is that on non-C languages (e.g. Python) bitopts would
>> look weird. And some features _might_ be non-boolean, but rather an
>> integers or strings.
>>
>> Maybe it would be better to introduce the new message with the set of
>> features that can be requested from criu? For now there will only be
>> one, the optional bool dirty_track, later we will be able to add more.
> 
> So you are thinking of something like:
> 
> message criu_features {
> 
> 	optional bool	dirty_track = 1;
> }
> 
> Which will then be included into the criu_req and criu_resp message?

Yes. And while time goes we will extend this thing further.