[CRIU] [PATCH] sysctl: typo fix

Tycho Andersen tycho.andersen at canonical.com
Mon Oct 5 06:19:46 PDT 2015


On Mon, Oct 05, 2015 at 04:01:59PM +0300, Andrey Vagin wrote:
> From: Andrew Vagin <avagin at openvz.org>
> 
> CID 152110 (#1 of 1): Logically dead code (DEADCODE)
> dead_error_line: Execution cannot reach this statement: goto out;.
> 
> Signed-off-by: Andrew Vagin <avagin at openvz.org>

Acked-by: Tycho Andersen <tycho.andersen at canonical.com>

> ---
>  sysctl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sysctl.c b/sysctl.c
> index 1c2f2fc..270d974 100644
> --- a/sysctl.c
> +++ b/sysctl.c
> @@ -227,7 +227,7 @@ static int __userns_sysctl_op(void *arg, int unused, pid_t pid)
>  		goto out;
>  
>  	reqs = xmalloc(sizeof(struct sysctl_req) * userns_req->nr_req);
> -	if (!fds)
> +	if (!reqs)
>  		goto out;
>  
>  	memset(fds, -1, sizeof(int) * userns_req->nr_req);
> -- 
> 2.4.3
> 
> _______________________________________________
> CRIU mailing list
> CRIU at openvz.org
> https://lists.openvz.org/mailman/listinfo/criu


More information about the CRIU mailing list