[CRIU] [PATCH] sysctl: add the "fallthrough" annotation

Andrey Vagin avagin at openvz.org
Mon Oct 5 06:01:40 PDT 2015


From: Andrew Vagin <avagin at openvz.org>

CID 152112 (#1 of 1): Missing break in switch (MISSING_BREAK)
unterminated_case: The case for value 4 is not terminated by a 'break' statement.

Signed-off-by: Andrew Vagin <avagin at openvz.org>
---
 sysctl.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sysctl.c b/sysctl.c
index fb028f6..1c2f2fc 100644
--- a/sysctl.c
+++ b/sysctl.c
@@ -170,6 +170,7 @@ static int do_sysctl_op(int fd, struct sysctl_req *req, int op)
 	switch (CTL_TYPE(req->type)) {
 	case __CTL_U32A:
 		nr = CTL_LEN(req->type);
+		/* fallthrough */
 	case CTL_U32:
 		__SYSCTL_OP(ret, fd, req, u32, nr, op);
 		break;
@@ -178,6 +179,7 @@ static int do_sysctl_op(int fd, struct sysctl_req *req, int op)
 		break;
 	case __CTL_U64A:
 		nr = CTL_LEN(req->type);
+		/* fallthrough */
 	case CTL_U64:
 		__SYSCTL_OP(ret, fd, req, u64, nr, op);
 		break;
-- 
2.4.3



More information about the CRIU mailing list