[CRIU] [PATCH] ptrace: don't stop a process if it was not in the stopped state

[Tycho Andersen]

On Thu, Oct 01, 2015 at 02:47:40PM +0300, Andrey Vagin wrote:
> From: Andrew Vagin <avagin at openvz.org>
> 
> Reported-by: Pavel Emelyanov <xemul at parallels.com>
> Cc: Tycho Andersen <tycho.andersen at canonical.com>

Acked-by: Tycho Andersen <tycho.andersen at canonical.com>

Sorry about that, should the malloc that fails above also goto err?

> Signed-off-by: Andrew Vagin <avagin at openvz.org>
> ---
>  ptrace.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/ptrace.c b/ptrace.c
> index 324b524..2b29492 100644
> --- a/ptrace.c
> +++ b/ptrace.c
> @@ -187,11 +187,11 @@ try_again:
>  
>  	} else if (!proc_status_creds_eq(*creds, &cr)) {
>  		pr_err("creds don't match %d %d\n", pid, ppid);
> -		goto err_stop;
> +		goto err;
>  	}
>  
>  	if (cr.seccomp_mode != SECCOMP_MODE_DISABLED && suspend_seccomp(pid) < 0)
> -		goto err_stop;
> +		goto err;
>  
>  	if (si.si_signo == SIGTRAP)
>  		return TASK_ALIVE;
> -- 
> 2.4.3
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ptrace-more-don-t-stop-a-process-if-not-in-the-stopp.patch
Type: text/x-diff
Size: 655 bytes
Desc: not available
URL: <http://lists.openvz.org/pipermail/criu/attachments/20151001/c9228f6c/attachment.bin>