[CRIU] [PATCH][RFC] zdtm: Move towards the new generation of criu testing

Christopher Covington cov at codeaurora.org
Thu Oct 1 05:59:37 PDT 2015


Hi Pavel,

On 10/01/2015 08:11 AM, Pavel Emelyanov wrote:
> Hi.
> 
> After recent set with fault-injection it seemed to me that the
> existing 1.2KLOC shell script would be quite hard to extend and
> maintain in the future. I propose to bring our test system onto
> the next level and write it on a more suitable language :)

Great idea.

> So, things to get fixed in the first place
> 
> 1. Introduce per-test extendable description. Right now this
>    description is scatered over test itself, .opts file, scripts
>    and the zdtm.sh itself (list forming and random hacks).
> 
>    In new approach all the tests' metadata is in the zdtm.list
>    file in yaml format.

So you've reduced the scattering from test, .opts, scripts, and zdtm.sh (4) to
test and zdtm.list (2). Do you think it's useful to have the information in
two places (the redundancy could help catch errors for example)? Why not have
all the information in the test? For example:

A) Build the list by recursively finding executables. This can take care of
the arch flag as there is no point building x86-specific tests for ARM and
Power (and some of them won't build even if you wanted to).

B) Determine the flags, flavor, opts, etc. by parsing the output of `$test
--help`.

Christopher Covington

-- 
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project


More information about the CRIU mailing list