[CRIU] [PATCH] Tests sysv5 msg queues
Pavel Emelyanov
xemul at parallels.com
Mon Nov 30 00:56:07 PST 2015
Repeating my concern about this patch.
>> @@ -0,0 +1,28 @@
>> +#include <stdlib.h>
>> +#include <sys/msg.h>
>> +
>> +#include "zdtmtst.h"
>> +
>> +const char *test_doc = "Block migration by holding a message queue";
>> +const char *test_author = "Pavel Emelianov <xemul at sw.ru>";
>> +
>> +int main(int argc, char ** argv)
>> +{
>> + int msg;
>> +
>> + test_init(argc, argv);
>> +
>> + msg = msgget(IPC_PRIVATE, IPC_CREAT | 0644);
>> + if (msg < 0) {
>> + err("msgget failed: %m");
>> + exit(1);
>> + }
>> +
>> + test_daemon();
>> + test_waitsig();
>> +
>> + msgctl(msg, IPC_RMID, 0);
This is not a test. At least not a zdtm one. Zdtm test should check its state after
waitsig() and fail in some conditions.
>> + pass();
>> + return 0;
>> +}
>>
>
More information about the CRIU
mailing list