[CRIU] [PATCH 5/5] p.haul: allow pass module specific command line arguments

[Pavel Emelyanov]

On 11/23/2015 04:26 PM, Nikita Spiridonov wrote:
> On Mon, 2015-11-23 at 12:47 +0300, Pavel Emelyanov wrote:
>>> +def __add_vz_client_args(parser):
>>> +	"""Add Virtuozzo client-specific arguments"""
>>> +	parser.add_argument("--vz-dst-ctid", help="ctid at destination")
>>
>> Htype-specific code should be in htype .py file.
>>
> 
> Ok, will fix it in v2, but there is some problems with such approach. On
> the one hand, we don't want to load unused haulers modules (i.e. want
> import only single actual hauler). On the other hand, we don't know
> which hauler to import on service side when we parse arguments since
> user specify hauler type explicitly only for phaul client.
> 
> So, I suggest to implement module specific arguments only for client at
> the present moment. Module specific arguments for phaul service can be
> implemented further if necessary (e.g. using "./p.haul-service ...
> --oneshot vz" syntax).

I don't get the need for service-side per-htype options. Everything
can (at least now) be controlled from the client side.