[CRIU] [PATCH 1/2] --freeze-cgroup: should also seize tasks in sub-cgroups

[Andrey Wagin]

2015-11-20 16:46 GMT+03:00 Andrew Vagin <avagin at virtuozzo.com>:
> On Thu, Nov 19, 2015 at 09:15:59AM -0700, Tycho Andersen wrote:
>> Signed-off-by: Tycho Andersen <tycho.andersen at canonical.com>
>> CC: Andrew Vagin <avagin at virtuozzo.com>
>> ---
>>  seize.c | 124 +++++++++++++++++++++++++++++++++++++++++++---------------------
>>  1 file changed, 84 insertions(+), 40 deletions(-)
>>
>> diff --git a/seize.c b/seize.c
>> index 943f9d1..3281dd0 100644
>> --- a/seize.c
>> +++ b/seize.c
....
>> +
>> +             if (seize_cgroup_tree(path, state) < 0) {
>
> I don't like this recursion. We don't know how deep it is, so are you
> sure that we will not have a problem with too big stack?
>

A default limit for user space stack is 8Mb, so it should be ok.
# ulimit -a
...
stack size              (kbytes, -s) 8192


Acked-by: Andrew Vagin <avagin at openvz.org>