[CRIU] [PATCH 2/3] net: allow c/r of empty bridges in the container

Pavel Emelyanov xemul at parallels.com
Wed Nov 11 08:05:50 PST 2015


>>>> You return "OK, let's dump it" when dir emptiness check fails, while
>>>> before the patch error resulted in error.
>>>
>>> if is_empty_dir() returns 0 (i.e. the dir is not empty), this returns
>>> -1 doesn't it?
>>
>> It does. But if is_empty_dir() returns -1, meaning "something went
>> wrong" this returns 0.
> 
> The patch tests for that above (after it closes the fd); it is a

Oops, yes :) I've overlooked that.

> little misleading, though. I can rearrange it if there is a better
> way.

No it's not... likely that's me reading the patch too fast.

-- Pavel



More information about the CRIU mailing list