[CRIU] p.haul and cpuinfo

[Adrian Reber]

On Mon, Nov 02, 2015 at 07:24:43PM +0300, Pavel Emelyanov wrote:
> On 11/02/2015 07:15 PM, Adrian Reber wrote:
> > Some CRIU supported architectures (all except x86) have not really
> > implemented the dump cpuinfo functionality. Running criu cpuinfo dump on
> > one of those arches returns 161 and that seems to break p.haul.
> > 
> > The problem seems to come from cpuinfo_dump() and cpuinfo_check() which
> > return -ENOTSUP. Which is correct as it is not implemented. I can work
> > around this in p.haul by using the parameter '--force' but I would
> > rather see this fixed correctly.
> > 
> > Should this be fixed in cpuinfo_dump()/cpuinfo_check(), cr-service.c or
> > in p.haul? 
> 
> I would say it's CRIU's fix, all the more so p.haul has the option
> --force that omits cpus validation.

So if cpuinfo_dump()/cpuinfo_check() are returning -ENOTSUP cr-service.c
should return success=true via RPC interface? It sounds like another
additional message is needed to let p.haul know that the cpuinfo dump
did not actually fail but that it is unsupported.

		Adrian