[CRIU] [PATCH 1/3] fsnotify: Add ability to force resolve paths for watchees

Cyrill Gorcunov gorcunov at gmail.com
Mon Nov 2 08:05:35 PST 2015


On Mon, Nov 02, 2015 at 06:51:42PM +0300, Pavel Emelyanov wrote:
> > 
> > diff --git a/crtools.c b/crtools.c
> > index d3812a18f4f0..243d90188ac8 100644
> > --- a/crtools.c
> > +++ b/crtools.c
> > @@ -253,6 +253,7 @@ int main(int argc, char *argv[], char *envp[])
> >  		{ "freeze-cgroup",		required_argument,	0, 1068 },
> >  		{ "ghost-limit",		required_argument,	0, 1069 },
> >  		{ "irmap-scan-path",		required_argument,	0, 1070 },
> > +		{ "force-inotify-path",		required_argument,	0, 1071 },
> 
> One more option is excessive here. There are 3 big blocks that are in the
> game here -- get inode handle, try to get the inode name, force FS scan to
> get the inode name. And the 2nd block is must-have for TMPFS or (with this
> patch) option. I propose to remove the option and make soft path lookup 
> happen always, but only to fail the dump for TMPFS-s. The forced FS scan
> should a) be performed iff the soft path resolve failed and b) still be
> under option, which should be turned on by p.haul rsync driver.

OK, I'll rework.


More information about the CRIU mailing list