[CRIU] [PATCH 2/2] test/Makefile: use the override directive

Christopher Covington cov at codeaurora.org
Fri May 15 04:58:37 PDT 2015


On 05/15/2015 07:30 AM, Andrew Vagin wrote:
> On Fri, May 15, 2015 at 02:27:59PM +0300, Pavel Emelyanov wrote:
>> Guys, what do we plan to do on this?
> 
> nothing. We could not find a better alternative.

Maybe if you just add comments to the original patch every time the
environment variable is used it would be clear enough what's going on.

I've started using target- and pattern-specific variables recently. Would this
be good?

zdtm-pre-dump: ZDTM_ARGS=-P -p -i 3 -C
zdtm-snapshot:  ZDTM_ARGS=-s -i 3 -C
zdtm-iter: ZDTM_ARGS=-i 3 -C

zdtm-pre-dump: zdtm-tst-list
	$(MAKE) ZDTM_ARGS=$(ZDTM_ARGS) -f Makefile.zdtm ns/static/pipe00

zdtm-snapshot: zdtm-tst-list
	$(MAKE) ZDTM_ARGS=$(ZDTM_ARGS) -f Makefile.zdtm ns/static/pipe00

zdtm-iter: zdtm-tst-list
	$(MAKE) ZDTM_ARGS=$(ZDTM_ARGS) -f Makefile.zdtm ns/static/pipe00

(If that works, the question that follows is whether these can be combined
with a [static] pattern rule or multiple target rule.)

Chris

-- 
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project


More information about the CRIU mailing list