[CRIU] [PATCH] Makefile: allow optional local rules

Andrey Wagin avagin at gmail.com
Fri May 1 11:16:56 PDT 2015


2015-05-01 20:59 GMT+03:00 Kir Kolyshkin <kir at odin.com>:
>
>
> On 05/01/2015 03:48 AM, Andrew Vagin wrote:
>>
>> On Thu, Apr 30, 2015 at 04:25:45PM -0700, Kir Kolyshkin wrote:
>>>
>>> I use Makefile.local to add my own rules for submitting a build
>>> to Coverity. As those rules contain login credentials, they should
>>> be kept private. Including Makefile.local (if present) seems to be
>>> the best way to achieve that.
>>>
>>> Also, add Makefile.local to .gitignore to make sure it never gets
>>> commited into repo.
>>
>> I use travis to submit buils to Coverity.
>>
>> https://github.com/avagin/criu/commit/d04645aef57fc40d8855746a206d72fb199225bd
>
>
> Thanks!
>
> This patch is not about Coverity though, but in general about an ability
> to have your own private Makefile rules (or redefine existing ones).

My answer isn't about Makefile. I can't say anything about Makefile.
It looks good for me.

>
>
>>
>>> Signed-off-by: Kir Kolyshkin <kir at openvz.org>
>>> ---
>>>   .gitignore | 1 +
>>>   Makefile   | 3 +++
>>>   2 files changed, 4 insertions(+)
>>>
>>> diff --git a/.gitignore b/.gitignore
>>> index b97a96e..bd1e61e 100644
>>> --- a/.gitignore
>>> +++ b/.gitignore
>>> @@ -15,6 +15,7 @@ criu
>>>   cscope*
>>>   tags
>>>   TAGS
>>> +Makefile.local
>>>   syscall-x86-64.S
>>>   include/syscall.h
>>>   include/syscall-codes.h
>>> diff --git a/Makefile b/Makefile
>>> index ed2a199..84ce2bb 100644
>>> --- a/Makefile
>>> +++ b/Makefile
>>> @@ -335,3 +335,6 @@ docker-test:
>>>         docker run --rm -it --privileged criu ./test/zdtm.sh -C -x tcp6
>>> -x tcpbuf6 -x static/rtc -x cgroup -x mountpoint
>>>     .DEFAULT_GOAL       := all
>>> +
>>> +# include optional local rules
>>> +-include Makefile.local
>>> --
>>> 1.9.3
>>>
>
> _______________________________________________
> CRIU mailing list
> CRIU at openvz.org
> https://lists.openvz.org/mailman/listinfo/criu


More information about the CRIU mailing list