[CRIU] [PATCH 2/2] test/Makefile: use the override directive

Cyrill Gorcunov gorcunov at gmail.com
Fri May 1 10:03:01 PDT 2015


On Fri, May 01, 2015 at 12:46:08PM -0400, Christopher Covington wrote:
> >>
> >> I find this more difficult to follow. What about something like:
> >>
> >>     Z="-P -p -i 3 -C"
> >>     $(MAKE) -f Makefile.zdtm ns/static/pipe00 ZDTM_ARGS=$(Z)
> > 
> > 
> > This doesn't work. I don't know why and I am not a big fun of
> > Makefiles:).
> 
> strace and/or $(warning ...) would probably explain why. I have a partially
> finished shell script replacement sitting around if you're interested. One of
> these days after fixing PAGE_SIZE, TASK_SIZE, and AArch64 VDSO I'll hopefully
> get back to it.

Don't assign variables inside rule target, iow better do

Z="something"
rule: bla-bla
	make $(Z)


More information about the CRIU mailing list