[CRIU] [RFC PATCH 0/6] introduce FSTYPE__AUTO

Cyrill Gorcunov gorcunov at gmail.com
Sat Mar 28 08:50:34 PDT 2015


On Sat, Mar 28, 2015 at 04:23:28PM +0100, Oleg Nesterov wrote:
> >
> > AND. More importantly. IMO, we want the command line option to support
> > the filesystems which can "just work". This is impossible with the
> > compiled-in fstypes[].
> >
> > Please review.
> 
> In case it was not clear, I didn't even meant the patches in the first
> place. The main question is: do you agree this feature makes sense?
> 
> 
> > Again, this is not for inclusion. 3/6 should be reimplemented (see the
> > changelog) and we need to populate the FSTYPE__AUTO entries earlier on
> > restore. Even for correctness. parse_mountinfo_ent() is called at the
> > start of restore afaics. But seems to work even if not 100% correct.
> 
> And we do not even need the changes in protobuf/mnt.proto. We only need
> to dump/restore the additional string (list of used FSTYPE__AUTO names).
> Can we (ab)use inventory_entry and inventory.img for that?

Hi Oleg. sorry for not replying, been too busy. In general I think the
idea is worth (!) implementing (the details of implementation is a different
question and we always may choose the way we prefer). Pavel?


More information about the CRIU mailing list