[CRIU] [PATCH] mount: always report ->mnt_id as decimal

Oleg Nesterov oleg at redhat.com
Thu Mar 26 09:08:05 PDT 2015


Ah, sorry, wrong subject, should be "[PATCH 0/1]".

On 03/26, Oleg Nesterov wrote:
>
> Cosmetic. but it took me MORE THAN ONE HOUR to realize that
>
> 	FS mnt ./boot dev 0xfc00001 root / unsupported id 67
>
> has nothing to do with the 67 mnt I see in /proc/$pid/mountinfo and
> in other parts of -vvvv output.
>
> I thought that this ->mnt_id was corrupted or miscalculated somehow,
> but after a lot of grepping I found the easter egg added by a giggling
> criu developer from CC list.
>
> Perhaps it makes sense to change fsnotify.c too, I dunno. But lets at
> least make proc_parse.c and mount.c consistent wrt ->mnt_id reporting.
>
> ./boot looks a bit confusing to imo, may be ->mountpoint + 1 will look
> a bit better, but this needs more changes.
>
> Oleg.



More information about the CRIU mailing list