[CRIU] [PATCH 0/4] A few fixes for testing engine and poll test

Cyrill Gorcunov gorcunov at openvz.org
Thu Mar 26 01:23:11 PDT 2015


 - in logging routines we're calling for functions which might
   modify global @errno while caller still might rely on its
   presistency. so lets save @errno locally and restore it
   on exit

 - in poll() test the gettimeofday() helper accesses /etc/localtime
   which is not present in our namespace environment causing test
   to fail. lets use native systemcall instead

 - in case if inotify_system_nodel.c in zdtm already present the
   testengine fails to proceed. this is not critical and might
   be a leftover from previous pass, so lets make symlink in
   a foce mode

I've been running static/poll and ns/static/poll tests without
problem when this series applied, but the complete testrun fails
with

 | make[2]: Entering directory `/home/cyrill/projects/criu/test'
 | ./zdtm.sh -l > zdtm-tst-list
 | ================================= CRIU CHECK =================================
 | Error (cr-check.c:665): AIO remap doesn't work properly
 | ============================= WARNING =============================
 | Not all features needed for CRIU are merged to upstream kernel yet,
 | so for now we maintain our own branch which can be cloned from:
 | git://git.kernel.org/pub/scm/linux/kernel/git/gorcunov/linux-cr.git
 | ===================================================================
 | 
 | make -f Makefile.zdtm zdtm_nons
 | make[3]: Entering directory `/home/cyrill/projects/criu/test'
 | gcc  -O2 -Wall -Werror -DCONFIG_X86_64 -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE -DCONFIG_HAS_LIBBSD -D_GNU_SOURCE -D_GNU_SOURCE -D_GNU_SOURCE    zdtm_ct.c   -o zdtm_ct
 | flock zdtm_mount_cgroups ./zdtm_mount_cgroups
 | mkdir: cannot create directory ‘zdtm.jGoiUq/holder’: File exists

which I have no clue how to resolve (happens even after make clean
in admin mode).

So take a look and it's up to you if it worth merging.

Cyrill Gorcunov (4):
  log: Don't modify global @errno in __print_on_level
  zdtm: Don't modify global @errno in test_msg
  test: poll -- Use gettimeofday syscall directly
  zdtm: make -- Don't fail if symlink already exist

 log.c                          |  2 ++
 test/zdtm/lib/msg.c            |  2 ++
 test/zdtm/live/static/Makefile |  2 +-
 test/zdtm/live/static/poll.c   | 24 +++++++++++++++++++++---
 4 files changed, 26 insertions(+), 4 deletions(-)

-- 
1.9.3



More information about the CRIU mailing list