[CRIU] [PATCH 1/2] finalize cgroups correctly

Pavel Emelyanov xemul at parallels.com
Tue Mar 24 10:57:51 PDT 2015


On 03/24/2015 08:25 PM, Saied Kazemi wrote:
> For the easy case of comparing pathname strings on the command line (-D and --root), I 
> think it's better to error and exit instead of restoring with all the cgyard mounts
> leaked into the restored process tree.

I rather agree with this. It's quite uncommon (from my perspective) that images sit
in the container's root, so preventing this usage doesn't (shouldn't) break anything
critical. Does it?

> For a more general solution, is it possible to make sure that after fini_cgroup() the 
> cgyard mount points have been successfully removed from the restored tree?

What if we call umount with detach flag on cgyard dir inside restore_task_mnt_ns()?
Would this resolve this?

Thanks,
Pavel



More information about the CRIU mailing list