[CRIU] [PATCH 1/2] finalize cgroups correctly

Tycho Andersen tycho.andersen at canonical.com
Tue Mar 24 07:13:29 PDT 2015


On Tue, Mar 24, 2015 at 11:26:31AM +0300, Pavel Emelyanov wrote:
> On 03/19/2015 05:50 PM, Tycho Andersen wrote:
> > We need to finalize the cg yard both on successful cgroup restore and on a
> > failed restore. Further, we should restore the cgroup properties before
> > allowing the task to continue in all modes (previously properties were only
> > restored correctly in --restore-detached mode).
> > 
> > CC: Saied Kazemi <saied at google.com>
> > Signed-off-by: Tycho Andersen <tycho.andersen at canonical.com>
> 
> Although we still have issue with --images-dir being subdir of --root it
> seems to be unrelated to this particular patch.
> 
> So I apply this one, thanks Tycho.

Thanks. I think the sanity check Saied suggested is a good one
(although perhaps it should be a warning instead of an error?); I can
send a patch for that if we decide what the output should be.

Tycho


More information about the CRIU mailing list