[CRIU] [PATCH] restore/x86: restore_gpregs() needs to initialize ->ss as well

Cyrill Gorcunov gorcunov at gmail.com
Thu Mar 19 09:30:15 PDT 2015


On Thu, Mar 19, 2015 at 05:14:33PM +0100, Oleg Nesterov wrote:
> Before the recent "x86_64,signal: Fix SS handling for signals delivered
> to 64-bit programs" kernel patch, sigreturn paths forgot to restore ->ss
> after return from the signal handler.
> 
> Now that the kernel was fixed, restore_gpregs() has to initialize ->ss
> too, it is no longer ignored.
> 
> Note: this is the minimal fix. In the long term we probably should not
> dump/restore the segment registers at all. We can use sigcontext filled
> by the target kernel and modify the general-purpose regs.
> 
> Reported-and-tested-by: Andrey Wagin <avagin at gmail.com>
> Signed-off-by: Oleg Nesterov <oleg at redhat.com>
Acked-by: Cyrill Gorcunov <gorcunov at openvz.org>

Thanks a huge, Oleg!


More information about the CRIU mailing list