[CRIU] [PATCH 1/2] don't assume the kernel has CONFIG_SECCOMP

[Tycho Andersen]

On Thu, Jun 25, 2015 at 06:15:43PM +0300, Pavel Emelyanov wrote:
> 
> >> Why is this required? If criu finds seccomp mark in /proc, then shouldn't
> >> it properly parse one?
> > 
> > The problem is when it doesn't have Seccomp:. We won't get to 9 things
> > parsed, even though we check for 9 things. I suppose it's not strictly
> > necessary in the while() loop, but the check for success below
> > requires it.
> 
> Ah, but then this check is not about CONFIG_HAS_SECCOMP (user space library) but
> purely about kernel. Either we meet one there or not, but we should not depend on 
> the userspace library presence.

We're not depending on the library presence, are we? The problem is
that a /proc/pid/status entry will simply not have a line containing
"Seccomp:" if it is kernel 3.11, but if we expect it to be there (by
requiring 9 successful things to parse), we will always fail on a 3.11
kernel.

Tycho