[CRIU] [PATCH] p.haul: allow specify module-specific criu request options

Tycho Andersen tycho.andersen at canonical.com
Tue Jun 23 08:45:05 PDT 2015


Hi Cyrill,

Sorry for the delay,

On Fri, Jun 19, 2015 at 06:13:59PM +0300, Cyrill Gorcunov wrote:
> On Fri, Jun 19, 2015 at 08:15:22AM -0600, Tycho Andersen wrote:
> > On Fri, Jun 19, 2015 at 02:06:01PM +0400, Nikita Spiridonov wrote:
> > > We have to specify multiple --ext-mount-map options in criu dump
> > > and restore requests during Virtuozzo container migration to make
> > > it work. To make it real add possibility that allow specify
> > > module-specific criu request options.
> > > 
> > > Now every phaul module (e.g. Virtuozzo or LXC) have method
> > > adjust_criu_req; any module-specific request options can be
> > > specified in this method.
> > 
> > Is this something we can use `--ext-mount-map auto` for? In
> > lxc-checkpoint, we're using that so we don't have to specify all these
> > by hand (including any extra bind mounts the user may have asked for).
> 
> Do you setup all the mounts as bindmount? I must admit i didn't
> look into "auto" details but how it resolves the paths?

Yep, they're all prepared as bind mounts. The --ext-mount-map auto
just does a mounts_equal() between mounts inside the container and
mounts in criu's mount ns, and if two of them are equal it counts that
as an external bind mount.

Tycho


More information about the CRIU mailing list