[CRIU] [PATCH 1/2] cgroups: Add ability to reuse existing cgroup yard directory

[Tycho Andersen]

On Mon, Jun 15, 2015 at 12:46:33PM +0300, Pavel Emelyanov wrote:
> On 06/12/2015 09:57 AM, Cyrill Gorcunov wrote:
> > On Fri, Jun 12, 2015 at 12:27:03AM -0600, Tycho Andersen wrote:
> >>>
> >>> Never headr of such thing. Still one can pass --cgroup-yard option
> >>> and define the directory to use instead of /sys/fs/cgroup (it should
> >>> be premounted by caller then).
> >>
> >> Right, of course, it's just a change in the default behavior. I
> >> thought there was some reason we didn't use /sys/fs/cgroup in the
> >> first place, but I can't remember what it is.
> > 
> > Yes, it's a change in def. behaviour. The first version of patches
> > used backward compatible manner -- ie until explicitly choosen via
> > --cgroup-yard temp yard has been created and mounted, but Pavel proposed
> > to drop it off.
> 
> The reason for our own cgyard was in -- if the host system lack some controller
> mounted, then we would need to create our own. But AFAIU all modern distros have
> full cgroup set mounted.
> 
> Do you think that I am over-optimistic and we should create cgyard ourselves?

No, I think you're right that most modern distros mount all the
cgroups. (And if not then they can upgrade to Ubuntu :D) The patch
sounds good to me if that was the only concern, consider both in the
series:

Acked-by: Tycho Andersen <tycho.andersen at canonical.com>

Tycho

> -- Pavel
>