[CRIU] [PATCH 5/5] pie: piegen -- Enable printing debug info during build

Laurent Dufour ldufour at linux.vnet.ibm.com
Tue Jun 9 23:48:59 PDT 2015


On 09/06/2015 22:25, Cyrill Gorcunov wrote:
> On Tue, Jun 09, 2015 at 02:25:16PM -0400, Christopher Covington wrote:
>>>
>>> It shows output (I think stdout/err only) in one place so
>>> there is no way to open some file (log file or any other
>>> file).
>>
>> Why can't you add `cat logfile` to scripts/travis-ci.sh?
> 
> I'm not really sure if it allows to. Same time I don't really
> like to write files here and there instead of one place.
> We've been chatting with Laurent and final conclusion is
> 
>  - prefix piegen output with custom slogan (passed via command
>    line) so in parallel build it will be possible to grep specified
>    data
> 
>  - verbose debug printing should be done iif V=1 is passed in
>    make arguments
> 
> I'm gonna implement all this on top of the series once time
> permit.
> 

Hi Cyrill,

I think one change we should made to piegen is to separate the output
file generated through pr_out() from the stdout stream. This way we
could have pr_out() writing to a file, pr_debug() writing to either
stdout or /dev/null and pr_err() writing to stderr.
This will allow to report error even if V=0.

I'll try to implement that today.

Cheers,
Laurent.



More information about the CRIU mailing list