[CRIU] [PATCH 5/5] pie: piegen -- Enable printing debug info during build

Cyrill Gorcunov gorcunov at gmail.com
Tue Jun 9 07:42:31 PDT 2015


On Tue, Jun 09, 2015 at 04:21:45PM +0200, Laurent Dufour wrote:
> On 09/06/2015 15:18, Cyrill Gorcunov wrote:
> > Helps to resolve build problems.
> > 
> > Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
> > ---
> >  pie/piegen/piegen.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/pie/piegen/piegen.h b/pie/piegen/piegen.h
> > index 5b0bc7917f07..6b852fcb0b93 100644
> > --- a/pie/piegen/piegen.h
> > +++ b/pie/piegen/piegen.h
> > @@ -25,7 +25,7 @@ extern int handle_elf_ppc64(const piegen_opt_t *opts, void *mem, size_t size);
> > 
> >  #define pr_out(fmt, ...)	fprintf(stdout, fmt, ##__VA_ARGS__)
> > 
> > -#if 0
> > +#if 1
> >  # define pr_debug(fmt, ...)	fprintf(stderr, fmt, ##__VA_ARGS__)
> >  #else
> >  # define pr_debug(fmt, ...)
> > 
> 
> This generates a lot of output and I think that only CRIU developpers
> would be interested in the detailed.
> I guess we may send the output in a log file. See patch attached.

No no. Yes it's suitable for developers mostly but if we move it to
the file I fear it won't be able to fetch output from automatisation
services like Travis. Let live with a bunch of debug info at least for
month or something.


More information about the CRIU mailing list