[CRIU] [PATCH 2/3] libcriu: move swrk launching code from restore_child to swrk_connect

[Kuprieiev Ruslan]

Should I do it on top of this set, or should I fix it and then send v3?

On 07/31/2015 03:40 PM, Pavel Emelyanov wrote:
> On 07/30/2015 11:40 PM, Ruslan Kuprieiev wrote:
>
>> diff --git a/lib/criu.h b/lib/criu.h
>> index 85f7788..d2196bf 100644
>> --- a/lib/criu.h
>> +++ b/lib/criu.h
>> @@ -143,6 +143,7 @@ typedef struct {
>>   		char		*service_address;
>>   		int		service_fd;
>>   	};
>> +	int			swrk_pid;
>>   } criu_opts;
>>   
>>   int criu_local_init_opts(criu_opts **opts);
>>
> I've just realized that this structure is in public header.
> Move it into lib/criu.c file and leave only abstract typedef
> in the header, so that libcriu users do not start referencing
> fields from it, thus pinning the structure layout from easy
> future modifications.
>
> -- Pavel