[CRIU] [PATCH] Fix GITID for release builds

Tycho Andersen tycho.andersen at canonical.com
Thu Jul 30 23:36:41 PDT 2015


On Fri, Jul 31, 2015 at 08:35:11AM +0200, Tycho Andersen wrote:
> On Thu, Jul 30, 2015 at 06:21:06PM +0300, Cyrill Gorcunov wrote:
> > On Thu, Jul 30, 2015 at 05:09:23PM +0200, Cédric Bosdonnat wrote:
> > > When building from the release tarballs, the criu.pc file always has
> > > version '0'. Getting a more sensible value for GITID provides proper
> > > version in the criu.pc for release builds.
> > > 
> > > Signed-off-by: Cédric Bosdonnat <cbosdonnat at suse.com>
> > 
> > Doesn't look correct for me. Cédric as been discussed on IRC
> > the main concern is GITID used in criu.pc file.
> > 
> > Tycho, why we change version to gitid there? It is a typo?
> 
> AFAIK it's a typo but I don't think it changed, it looks like it's
> always been like that.

Oh, sorry, I thought this was the second patch. Yes, this one doesn't
look quite correct, but v2 is okay I think.

Tycho


More information about the CRIU mailing list