[CRIU] [PATCH] Fix GITID for release builds

Pavel Emelyanov xemul at parallels.com
Thu Jul 30 08:16:07 PDT 2015


On 07/30/2015 06:09 PM, Cédric Bosdonnat wrote:
> When building from the release tarballs, the criu.pc file always has
> version '0'. Getting a more sensible value for GITID provides proper
> version in the criu.pc for release builds.
> 
> Signed-off-by: Cédric Bosdonnat <cbosdonnat at suse.com>
> ---
>  scripts/Makefile.version | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/Makefile.version b/scripts/Makefile.version
> index 8905bd9..fad6a24 100644
> --- a/scripts/Makefile.version
> +++ b/scripts/Makefile.version
> @@ -5,7 +5,7 @@ GITID_FILE := .gitid
>  GITID := $(shell if [ -d ".git" ]; then git describe; fi)
>  
>  ifeq ($(GITID),)
> -	GITID := 0
> +	GITID := $(CRTOOLSVERSION)

I would say that this

        $(Q) sed -e 's, at version@,$(GITID),' \

part in the Makefile's install-criu target should be fixed, bcause
GITID variable is just the id from git head.

Tycho?

-- Pavel


More information about the CRIU mailing list