[CRIU] [PATCH 1/3] Add dumping of unnamed unix sockets.

Pavel Emelyanov xemul at parallels.com
Wed Jul 29 07:56:42 PDT 2015


OK, applied, thanks!

Please, update the http://criu.org/Inheriting_FDs_on_restore page with
the info that unix sockets inheritance also works now.

And one more thing:

> @@ -278,6 +279,8 @@ int main(int argc, char *argv[], char *envp[])
>  			opts.final_state = TASK_ALIVE;
>  			break;
>  		case 'x':
> +			if (optarg && unix_sk_ids_parse(optarg) < 0)
> +				return 1;
>  			opts.ext_unix_sk = true;
>  			break;
>  		case 'p':

This hunk means that once I told -x 1234 all other external sockets
that can be auto-externalized will be handled. I'm not sure this
meets user expectations. Can we fix this option so that -x <number>
doesn't turn on wild-carded -x?

-- Pavel


More information about the CRIU mailing list