[CRIU] [PATCH] files-reg: Adjust file position for /dev/kmsg

Pavel Emelyanov xemul at parallels.com
Mon Jul 20 10:09:49 PDT 2015


On 07/20/2015 07:57 PM, Cyrill Gorcunov wrote:
> On Mon, Jul 20, 2015 at 07:49:31PM +0300, Pavel Emelyanov wrote:
>>
>> && rfe->pos == 0, we don't want to screw up somehow changed pos, do we?
> 
> yeah, thanks! updated
> 

There were two comments from me ;) The 2nd one was

> @@ -853,6 +870,8 @@ int dump_one_reg_file(int lfd, u32 id, const struct fd_parms *p)
>  		rfe.size = p->stat.st_size;
>  	}
>  
> +	adjust_file_pos(p, &rfe);

Plz, don't put it into generic function. Declare ops for dump_chrdev's
MEM_MAJOR case and fix this up there.

-- Pavel



More information about the CRIU mailing list