[CRIU] [PATCH] libcriu: don't include rpc.pb-c.h into criu.h

[Ruslan Kuprieiev]

On 07/17/2015 07:14 PM, Pavel Emelyanov wrote:
> On 07/17/2015 07:00 PM, Ruslan Kuprieiev wrote:
>>
>> On 07/17/2015 03:11 PM, Pavel Emelyanov wrote:
>>>> @@ -133,6 +132,8 @@ int criu_dump_iters(int (*more)(criu_predump_info pi));
>>>>     * structure and lets you set individual options in it.
>>>>     */
>>>>    
>>>> +typedef struct _CriuOpts CriuOpts;
>>> Asterisk missing.
>> Sorry for a stupid question, but why do we need it?
>> Isn't opaque struct definition not enough?
>>
>>>> +
>>>>    typedef struct {
>>>>    	CriuOpts		*rpc; /* Generic RPC options in protobuf format */
> Ah, you have one here :) Sorry. But typically the typedef
> defines the pointer and that's the way these things are
> declared in protobuf-generated headers.

Well, in rpc.pb-c.h I see

typedef struct _CriuOpts CriuOpts;


So is this patch okay?


>
>>>>    	int			(*notify)(char *action, criu_notify_arg_t na);
>>>>
>>> _______________________________________________
>>> CRIU mailing list
>>> CRIU at openvz.org
>>> https://lists.openvz.org/mailman/listinfo/criu
>> .
>>