[CRIU] [PATCH 1/3] libcriu: use criu_opts structure to keep all the options

[Pavel Emelyanov]

On 07/15/2015 04:45 AM, Ruslan Kuprieiev wrote:
> criu_opts contains rpc options and notify callback,
> so we can keep all options in just one structure.
> This will allow us to easily extend libcriu functionality
> and yet keep all options in one place.
> 
> We're also not hiding rpc opts structure anymore, so
> it is pretty clear where power-user should put his own
> CriuOpts instance if he would like to do that.
> 
> Signed-off-by: Ruslan Kuprieiev <rkuprieiev at cloudlinux.com>

Applied, one question inline.

> ---
>  Makefile   |   2 +-
>  lib/criu.c | 469 ++++++++++++++++++++++++-------------------------------------
>  lib/criu.h |  81 ++++++-----
>  3 files changed, 228 insertions(+), 324 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 6ed4c90..d67ed0b 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -161,7 +161,7 @@ SYSCALL-LIB	:= $(ARCH_DIR)/syscalls.built-in.o
>  ARCH-LIB	:= $(ARCH_DIR)/crtools.built-in.o
>  CRIU-SO		:= libcriu
>  CRIU-LIB	:= lib/$(CRIU-SO).so
> -CRIU-INC	:= lib/criu.h include/criu-plugin.h include/criu-log.h protobuf/rpc.proto
> +CRIU-INC	:= lib/criu.h include/criu-plugin.h include/criu-log.h protobuf/rpc.proto protobuf/rpc.pb-c.h

Why is this required?

>  ifeq ($(piegen-y),y)
>  piegen		:= pie/piegen/piegen
>  endif