[CRIU] [PATCH] proc: show a string in a error message if we can't parse it

[Andrey Vagin]

2015-07-15 19:12 GMT+03:00 Ross Boucher <rboucher at gmail.com>:
> Here's the mount info (I gathered it yesterday):
>
> 95 94 0:43 / /sys/fs/cgroup rw,nosuid,nodev,noexec,relatime - tmpfs  rw

Here are two spaces between tmpfs and rw. /sys/fs/cgroup was mounted
with empty "source" argument.

It's very easy to reproduce without docker:

mount -t tmpfs "" /sys/fs/cgroup

>
> But I believe its actually a bug in Docker that they're aware of and I
> believe they are working on a fix.
>
>
> On Wed, Jul 15, 2015 at 7:53 AM, Andrey Vagin <avagin at openvz.org> wrote:
>>
>> Hi Ross,
>>
>> Could you apply this patch and show dump.log again. Thanks.
>>
>> 2015-07-15 17:50 GMT+03:00 Andrey Vagin <avagin at openvz.org>:
>> > Signed-off-by: Andrey Vagin <avagin at openvz.org>
>> > ---
>> >  proc_parse.c | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/proc_parse.c b/proc_parse.c
>> > index e940fc1..5b26b32 100644
>> > --- a/proc_parse.c
>> > +++ b/proc_parse.c
>> > @@ -1109,7 +1109,7 @@ struct mount_info *parse_mountinfo(pid_t pid,
>> > struct ns_id *nsid, bool for_dump)
>> >
>> >                 ret = parse_mountinfo_ent(str, new, &fsname);
>> >                 if (ret < 0) {
>> > -                       pr_err("Bad format in %d mountinfo\n", pid);
>> > +                       pr_err("Bad format in %d mountinfo: '%s'\n",
>> > pid, str);
>> >                         goto end;
>> >                 }
>> >
>> > --
>> > 2.1.0
>> >
>
>