[CRIU] failure dumping nginx in docker container

Cyrill Gorcunov gorcunov at gmail.com
Thu Jul 2 14:04:12 PDT 2015


On Thu, Jul 02, 2015 at 09:45:09AM -0700, Ross Boucher wrote:
>    Yes, thanks for your patch Andrew. Cyrill, here are two sets of
>    dump/restore logs. The one's titled "working" are with Andrew's patch, the
>    one's titled "not-working" are from master (as of yesterday). 
>    https://gist.github.com/boucher/3bcb9f0c98d05a819974
>    (even though it says "not-working.dump" the dump part works just fine, its
>    only the restore that fails)
>    These were produced by building docker with criu support and running the
>    container with the default command from the "nginx" image.

Could you please give the patch attached a shot?
-------------- next part --------------
diff --git a/cgroup.c b/cgroup.c
index a4e0146e75ad..ec826840b0d4 100644
--- a/cgroup.c
+++ b/cgroup.c
@@ -1191,7 +1191,6 @@ static int prepare_cgroup_sfd(CgroupEntry *ce)
 				opt, sizeof(opt));
 
 		/* Create controller if not yet present */
-		if (access(paux, F_OK)) {
 			pr_debug("\tMaking controller dir %s (%s)\n", paux, opt);
 			if (mkdir(paux, 0700)) {
 				pr_perror("\tCan't make controller dir %s", paux);
@@ -1201,7 +1200,6 @@ static int prepare_cgroup_sfd(CgroupEntry *ce)
 				pr_perror("\tCan't mount controller dir %s", paux);
 				return -1;
 			}
-		}
 
 		/*
 		 * Finally handle all cgroups for this controller.


More information about the CRIU mailing list