[CRIU] [PATCH] make: protobuf -- Rework build procedure

Filipe Brandenburger filbranden at google.com
Wed Jan 28 12:10:49 PST 2015


Hi Chris,

On Wed, Jan 28, 2015 at 11:25 AM, Christopher Covington
<cov at codeaurora.org> wrote:
> Something that would be nice to have that the current build system does not
> handle is out-of-tree building. When I say out-of-tree building, I mean all
> configure, build, run, etc. artifacts are placed in a directory outside of the
> source tree.

+1

autotools handles that gracefully and running `make distcheck` does
actually test that out-of-tree build works from a read-only source
tree.

My offer to convert to autotools still stands, I'd be happy to
contribute the new build system, set up Travis CI to test that the
build system is working as expected (mainly ensuring `make distcheck`
works) and helping answer questions about how to extend/maintain the
system, just let me know if you'd be willing to take that patch and I
can send a proof-of-concept of it.

> Autotools generated configure scripts seem to take a while, which can be
> annoying, but again, not enough for me to really do something about like
> figuring out how to set up a site pre-configuration.

I agree that's an issue but on the normal develop/build/test cycle
(i.e. if you're mainly doing changes to an existing .c file) configure
doesn't need to re-run often, so for the incremental make case it
shouldn't be a terrible slowdown.

Cheers,
Filipe


More information about the CRIU mailing list