[CRIU] [PATCH 1/2] zdtm.sh: don't allow anyone to print on stdout

Christopher Covington cov at codeaurora.org
Wed Jan 28 07:38:00 PST 2015


There's not commit message to explain why you want this. Why do you want this?

Thanks,
Chris

On 01/22/2015 04:07 PM, Andrey Vagin wrote:
> Signed-off-by: Andrey Vagin <avagin at openvz.org>
> ---
>  test/zdtm.sh | 15 +++++++++++++--
>  1 file changed, 13 insertions(+), 2 deletions(-)
> 
> diff --git a/test/zdtm.sh b/test/zdtm.sh
> index 01bcbec..fa6b4bc 100755
> --- a/test/zdtm.sh
> +++ b/test/zdtm.sh
> @@ -1,5 +1,10 @@
>  #!/bin/bash
>  
> +# duplicate stdout into 3
> +exec 3<&1
> +# duplicate stderr into stdout
> +exec 1>&2
> +
>  ARCH=`uname -m | sed			\
>  		-e s/i.86/i386/		\
>  		-e s/sun4u/sparc64/	\
> @@ -541,7 +546,13 @@ start_test()
>  		rm -f $ZDTM_PIDFILE
>  	fi
>  
> -	if ! make -C $tdir $tname.pid; then
> +	(
> +		# Here is no way to set FD_CLOEXEC on 3
> +		exec 3>&-
> +		make -C $tdir $tname.pid
> +	)
> +
> +	if [ $? -ne 0 ]; then
>  		echo ERROR: fail to start $test
>  		return 1
>  	fi
> @@ -1025,7 +1036,7 @@ while :; do
>  		shift
>  		;;
>  	  -l)
> -		echo $TEST_LIST | tr ' ' '\n'
> +		echo $TEST_LIST | tr ' ' '\n' >&3
>  		exit 0
>  		;;
>  	  -v)
> 


-- 
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project


More information about the CRIU mailing list