[CRIU] [PATCH] Rework fixup_aufs_vma_fd() for non-AUFS links
Pavel Emelyanov
xemul at parallels.com
Thu Jan 22 09:32:47 PST 2015
On 01/22/2015 08:26 PM, Saied Kazemi wrote:
> Thanks Pavel.
>
> Just a quick note that building a fresh clone as of commit f3bf749b2b fails with this error:
>
> bfd.c:128:2: error: implicit declaration of function ‘close_safe’ [-Werror=implicit-function-declaration]
>
> So I added #include "util.h" to bfd.c.
>
> I am curious why the build hasn't failed for anyone else!
It was, but I have committed the fix only now :)
> --Saied
>
>
>
> On Thu, Jan 22, 2015 at 3:58 AM, Pavel Emelyanov <xemul at parallels.com <mailto:xemul at parallels.com>> wrote:
>
> On 01/22/2015 02:22 AM, Saied Kazemi wrote:
> > This patch reworks fixup_aufs_vma_fd() to let symbolic links in
> > /proc/<pid>/map_files that are not pointing to AUFS branch names follow
> > the non-AUFS applcation logic.
> >
> > The use case that prompted this commit was an application mapping
> > /dev/zero as shared and writeable which shows up in map_files as:
> >
> > lrw------- ... 7fc5c5a5f000-7fc5c5a60000 -> /dev/zero (deleted)
> >
> > If the AUFS support code reads the link, it will have to strip off the
> > " (deleted)" string added by the kernel but core CRIU code already
> > does this.
> >
> > Signed-off-by: Saied Kazemi <saied at google.com <mailto:saied at google.com>>
>
> Applied, thanks!
>
>
More information about the CRIU
mailing list