[CRIU] [PATCH] protobuf: copy descriptor.proto instead of using a link

Pavel Emelyanov xemul at parallels.com
Thu Jan 22 05:06:11 PST 2015


On 01/21/2015 11:59 PM, Ruslan Kuprieiev wrote:
> 
> On 01/21/2015 10:33 PM, Pavel Emelyanov wrote:
>> On 01/21/2015 11:26 PM, Ruslan Kuprieiev wrote:
>>>> This will allow us to drop protobuf-devel dependency for
>>>> building criu and crit.
>> I see no problems with such dependency. But what I_would_  do
>> is address Saied's concern about symlinks in the code. And
>> used the -I option to protoc-c.
>>
> 
> Our build system for protobuf can't use proto files that are
> located in other place than inside protobuf dir.
> 
> Why using a link is so bad?

Because on different systems this file can be in different locations.
And having this path as makefile variable would allow us to evaluate
one compile-time and pass proper option to proco-c. Changing symlink
compile-time would be not that easy and nice.




More information about the CRIU mailing list