[CRIU] [PATCH] make: protobuf -- Rework build procedure

Cyrill Gorcunov gorcunov at gmail.com
Thu Jan 22 02:00:20 PST 2015


On Wed, Jan 21, 2015 at 01:57:07PM +0200, Ruslan Kuprieiev wrote:
> 
> On 01/21/2015 01:49 PM, Cyrill Gorcunov wrote:
> >Instead of generating intermideate files with .SECONDARY
> >helper lets calculate proto deps on the fly.
> >
> >Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
> >---
> >  protobuf/Makefile | 84 ++++++++++++++++++++-----------------------------------
> >  1 file changed, 31 insertions(+), 53 deletions(-)
> >
> >Guys, could you please test this patch out and tell me if
> >it resolves all the problems for you.
> 
> Hell yeah! It solves all my problems =)
>
> For my education, could you please explain what was the problem?

Sorry for delay. Basically the problem was that deps were not
well generated (we used -include statement in secondary target
so that make simply were missing that there is a dep over opts).
Now we generate explicit deps very early so that make can generate
internal deps graph properly. Something like that ;)


More information about the CRIU mailing list