[CRIU] [PATCH] make: protobuf -- Rework build procedure

[Ruslan Kuprieiev]

Yes, we use custom field options to mark fields that need to be treated in a
special way when converting to json and back. Currently we only use hex 
option,
which tells CRIT to represent a field as a hex string, instead of 
decimal integer,
because json doesn't support hex notation for integers.

Unfortunately, I couldn't find a way to make protoc-c compile everything 
properly
without this link.

On 01/21/2015 08:43 PM, Saied Kazemi wrote:
> Thanks for your quick reply.
>
> Yes, that solved the problem.  The failure was confusing because I was 
> compiling for months without any issues even when using -j.  Anyway, I 
> see that after commit "crit: add --format hex option", one has to 
> install libprotobuf-dev for make to work.
>
> --Saied
>
> P.S. Isn't having a symbolic link in the build system to a hard coded 
> pathname fragile?
>
>
> On Wed, Jan 21, 2015 at 10:36 AM, Ruslan Kuprieiev <kupruser at gmail.com 
> <mailto:kupruser at gmail.com>> wrote:
>
>     Hi Saied,
>
>     That is probably because you don't have protobuf-devel package
>     installed.
>     We now have it as a dependency.
>
>     Could you install it and try again?
>
>     Thanks,
>     Ruslan
>
>
>
>     On 01/21/2015 08:25 PM, Saied Kazemi wrote:
>>     Hi Cyrill,
>>
>>     I applied the patch and made sure to start with a clean slate but
>>     ran into the following error:
>>
>>     grep: protobuf/google/protobuf/descriptor.proto: No such file or
>>     directory
>>
>>     Haven't looked into it yet, just wanted to report back before long.
>>
>>     --Saied
>>
>>
>>
>>     On Wed, Jan 21, 2015 at 3:49 AM, Cyrill Gorcunov
>>     <gorcunov at openvz.org <mailto:gorcunov at openvz.org>> wrote:
>>
>>
>>         Instead of generating intermideate files with .SECONDARY
>>         helper lets calculate proto deps on the fly.
>>
>>         Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org
>>         <mailto:gorcunov at openvz.org>>
>>         ---
>>          protobuf/Makefile | 84
>>         ++++++++++++++++++++-----------------------------------
>>          1 file changed, 31 insertions(+), 53 deletions(-)
>>
>>         Guys, could you please test this patch out and tell me if
>>         it resolves all the problems for you.
>>
>>         _______________________________________________
>>         CRIU mailing list
>>         CRIU at openvz.org <mailto:CRIU at openvz.org>
>>         https://lists.openvz.org/mailman/listinfo/criu
>>
>>
>>
>>
>>     _______________________________________________
>>     CRIU mailing list
>>     CRIU at openvz.org  <mailto:CRIU at openvz.org>
>>     https://lists.openvz.org/mailman/listinfo/criu
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openvz.org/pipermail/criu/attachments/20150121/2a427ea9/attachment.html>